-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang,windows: fix passing link flags when using clang in GNU frontend mode on windows #566
clang,windows: fix passing link flags when using clang in GNU frontend mode on windows #566
Conversation
…d mode on windows
Looks good to me, but it wouldn't harm to add a CI test for clang with gnu frontend targetting msvc abi. |
You just use clang as compiler instead of clang-cl and use GNU style flags. I'll take a look at adding a test |
… frontend mode on windows" This reverts commit 7c716e9.
This is only required in 1.81+, so temporarily bumping rust version in CI to make sure it fails with the expected error, then i'll un-revert |
…U frontend mode on windows" This reverts commit 9ef8a80.
I'm realizing if we had just updated corrosion it would have worked fine because of #537, oops. I still think this is a good change, but I'll fix it's interaction with 537 |
I'm confused now - Is the |
The -Wl, is required when using clang to invoke the linker. This fix isn't necessary in my case because #537 removes So this change is still correct, just not needed on the current rust compiler which |
Followup to #511 but adding support for GNU-style clang flags.
The condition is really CMAKE_CXX_COMPILER_FRONTEND_VARIANT==GNU && CMAKE_CXX_LINK_EXECUTABLE starts with ${CMAKE_CXX_COMPILER}, but they are always set together, and I doubt cmake would change that.
For msvc frontends, cmake directly invokes the linker so the passing the flags verbatim is still what we want to do.